[webkit-reviews] review granted: [Bug 67172] Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac : [Attachment 105638] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 30 09:48:31 PDT 2011


Kenneth Russell <kbr at google.com> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 67172: Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add
a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Attachment 105638: Patch
https://bugs.webkit.org/attachment.cgi?id=105638&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105638&action=review


Looks good. r=me

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:68
> +    GraphicsContext3D* m_graphicsContext3D;

Explicitly comment that this is weak?


More information about the webkit-reviews mailing list