[webkit-reviews] review denied: [Bug 66937] Padding size of input type search element is not locked on Webkit-GTK : [Attachment 105182] Patch

Tue Aug 30 09:35:47 PDT 2011

Martin Robinson <mrobinson at webkit.org> has denied Sameer Patil
<mkrp87 at motorola.com>'s request for review:
Bug 66937: Padding size of input type search element is not locked on
Webkit-GTK
https://bugs.webkit.org/show_bug.cgi?id=66937

Attachment 105182: Patch
https://bugs.webkit.org/attachment.cgi?id=105182&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105182&action=review

> Source/WebCore/ChangeLog:11
> +	   * platform/gtk/RenderThemeGtk.cpp:
> +	   (WebCore::RenderThemeGtk::adjustSearchFieldStyle):

Please fill these in.

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:375
> +    if (e && e->focused() &&
e->document()->frame()->selection()->isFocusedAndActive())
> +	   style->setOutlineOffset(-2);

I don't see this on other platforms at all. It seems unrelated. Why is it here?

> LayoutTests/fast/forms/search-styled-padding.html:15
> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
> +   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> +<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
> +<head>
> +<style>
> +.inputtext,
> +.inputpassword{border:1px solid #bdc7d8;font-family:"lucida grande", tahoma,
verdana, arial, sans-serif;font-size:11px;padding:3px;}
> +.inputsearch{background:white url(./resources/apple.gif) no-repeat 3px
4px;padding-left:17px;padding-bottom: 100px;}
> +</style>
> +
> +</head>
> +<body>
> +<input type="search" class="inputtext inputsearch" title="Search for Events"
placeholder="Search for Events" id="q_dashboard" name="q" value="" results="10"
/>
> +</body>
> +</html>

It seems like this test case could be greatly simplified. Should a text input
type="search" field with some padding suffice? Is this covered by any existing
tests? Be sure to generate your results with HEAD, as we've switched to GTK+
3.x now.