[webkit-reviews] review denied: [Bug 67192] API to set initial focus in gtk webkit : [Attachment 105619] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 67192: API to set initial focus in gtk webkit
https://bugs.webkit.org/show_bug.cgi?id=67192

Attachment 105619: Patch
https://bugs.webkit.org/attachment.cgi?id=105619&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105619&action=review


> Source/WebKit/gtk/webkit/webkitwebview.cpp:4026
> +void webkit_web_view_set_initial_focus(WebKitWebView* webView, gboolean
forward)

This needs API documentation and a unit test.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4027
> +{

Why no g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4030
> +    Page* page = core(webView);
> +
> +    if (page && page->focusController()) {

Please use an early return here.