[webkit-reviews] review denied: [Bug 67190] A Media Element ie: <Audio> or <video>, without tabindex cannot be selected with keyboard (TAB Key). : [Attachment 105607] updated Patch.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Deepak Sherveghar
<bpwv64 at motorola.com>'s request for review:
Bug 67190: A Media Element ie: <Audio> or <video>,  without tabindex cannot be
selected with keyboard (TAB Key).
https://bugs.webkit.org/show_bug.cgi?id=67190

Attachment 105607: updated Patch.
https://bugs.webkit.org/attachment.cgi?id=105607&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105607&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:227
> +bool HTMLMediaElement::supportsFocus() const
> +{
> +    return true;
> +}

This is not correct, the spec says a media element is only interactive when it
has the 'controls' attribute. From
http://www.w3.org/TR/html5/embedded-content-0.html#interactive-content:

    Interactive content is content that is specifically intended for user
interaction.

	=> ... audio (if the controls attribute is present) ... video (if the
controls attribute is present)