[webkit-reviews] review granted: [Bug 67182] [WebSocket] Prevent unnecessary pywebsocket warning on layout tests : [Attachment 105586] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 67182: [WebSocket] Prevent unnecessary pywebsocket warning on layout tests
https://bugs.webkit.org/show_bug.cgi?id=67182

Attachment 105586: Patch
https://bugs.webkit.org/attachment.cgi?id=105586&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105586&action=review


>>> LayoutTests/ChangeLog:11
>>> +	     This change make raise AbortedByUserException instead of
Exception.
>> 
>> Does pywebsocket 0.6b2 have AbortedByUserException?
> 
> No. 0.6b2 doesn't have.
> Actually, 0.6b3 changes Exception handling to support http fallback in
unexpected closure.
> Then, 0.6b4 introduce AbortedByUserException to eliminate http fallback.

I see.
I wondered why this patch didn't fail on cr-linux EWS with pywebsocket 0.6b2.
Probably the updated scripts crashed because of no
handshake.AortedByUserException.