[webkit-reviews] review denied: [Bug 66929] [Qt] REGRESSION(93767): Two tests fail with newer pywebsocket : [Attachment 105361] Patch (update ChangeLog)

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 66929: [Qt] REGRESSION(93767): Two tests fail with newer pywebsocket
https://bugs.webkit.org/show_bug.cgi?id=66929

Attachment 105361: Patch (update ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=105361&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105361&action=review


Need more explanations in ChangeLog.

> LayoutTests/ChangeLog:3
> +	   Two tests fail with newer pywebsocket.

Please write what problem is solved, or what we change concretely.

> LayoutTests/ChangeLog:10
> +	   close-unref-websocket tests call close() before GC. But, close()
> +	   itself queues close event. These close() must not be called to test
> +	   GC causes close event.

Why does this cause a problem on Qt + new pywebsocket, and not on other
platforms?

> LayoutTests/ChangeLog:13
> +	   its implementation is rough and results in unstable behavior.

Could you explain how rough it is, why does it make tests unstable, and why has
Qt a problem please?