[webkit-reviews] review granted: [Bug 65800] SVG panning y-axis is flipped on Windows and WebKit2/Mac : [Attachment 105543] with cr-linux results (?)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 65800: SVG panning y-axis is flipped on Windows and WebKit2/Mac
https://bugs.webkit.org/show_bug.cgi?id=65800

Attachment 105543: with cr-linux results (?)
https://bugs.webkit.org/attachment.cgi?id=105543&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105543&action=review


> Source/WebCore/page/EventHandler.cpp:477
> +	       FrameView* view = m_frame->view();
> +	      
static_cast<SVGDocument*>(m_frame->document())->startPan(view->windowToContents
(event.event().pos()));

Why the local variable? I think it would read better without it.

> Source/WebCore/page/EventHandler.cpp:1566
> +	   FrameView* view = m_frame->view();
> +	  
static_cast<SVGDocument*>(m_frame->document())->updatePan(view->windowToContent
s(m_currentMousePosition));

Ditto.

> Source/WebCore/page/EventHandler.cpp:1688
> +	   FrameView* view = m_frame->view();
> +	  
static_cast<SVGDocument*>(m_frame->document())->updatePan(view->windowToContent
s(m_currentMousePosition));

Ditto.