[webkit-reviews] review granted: [Bug 67152] Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement : [Attachment 105528] made setLastChangeWasNotUserEdit protected

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 67152: Move setInnerTextValue from RenderTextControl to
HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152

Attachment 105528: made setLastChangeWasNotUserEdit protected
https://bugs.webkit.org/attachment.cgi?id=105528&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105528&action=review


Please do your best to make the Windows build work by editing the .def file.
EWS might have enough information for you to do that.

> Source/WebCore/html/HTMLTextAreaElement.cpp:336
> +    setLastChangeWasNotUserEdit();

Really could land this bug fix separately. Why not do that?

> Source/WebCore/html/HTMLTextFormControlElement.h:103
> +    void setLastChangeWasNotUserEdit() { m_lastChangeWasUserEdit = false; }
>  private:

Should have a blank line here.