[webkit-reviews] review denied: [Bug 67009] Clicking causes dirty rects that may be unnecessary; this affects future optimizations. : [Attachment 105520] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 67009: Clicking causes dirty rects that may be unnecessary; this affects
future optimizations.
https://bugs.webkit.org/show_bug.cgi?id=67009

Attachment 105520: Patch
https://bugs.webkit.org/attachment.cgi?id=105520&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105520&action=review


> Source/WebCore/ChangeLog:10
> +	   Tests N/A

It’s not true that tests are not applicable to a change like this. We do want
to come up with a way to test a change like this.

> Source/WebCore/editing/FrameSelection.cpp:1222
> -    m_absoluteCaretRepaintBounds =
caretRepaintRect(m_selection.start().deprecatedNode());
> +    m_absoluteCaretRepaintBounds = m_selection.isNone() ?
caretRepaintRect(m_selection.start().deprecatedNode()) : LayoutRect();

This change means that when you are changing the selection to none, we won’t
erase the old caret. That’s not correct.