[webkit-reviews] review denied: [Bug 67155] [Qt] QDesktopWebView url property test missing : [Attachment 105523] url property test for DesktopWebView

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Gopal Raghavan
<gopal.1.raghavan at nokia.com>'s request for review:
Bug 67155: [Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155

Attachment 105523: url property test for DesktopWebView
https://bugs.webkit.org/attachment.cgi?id=105523&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105523&action=review


> Source/WebKit2/ChangeLog:8
> +	   Added qml test case to check url property

Period at end of sentence please.

>
Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qm
l:30
> +	       var tstUrl = Qt.resolvedUrl("../common/test1.html")
> +	       webView.load(tstUrl)
> +	       spy.wait()
> +	       compare(webView.url, tstUrl)
> +	   }

This doesn't test anything. Please test that the page actually loaded, e.g. by
testing that the title has changed (like the test above it).
Also, use testUrl instead of tstUrl. Abbvs don't smplfy reading the code :)