[webkit-reviews] review granted: [Bug 65050] Replace preprocessor statements in DOMWindow.idl with Conditional attribute : [Attachment 101775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 29 12:41:53 PDT 2011


Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 65050: Replace preprocessor statements in DOMWindow.idl with Conditional
attribute
https://bugs.webkit.org/show_bug.cgi?id=65050

Attachment 101775: Patch
https://bugs.webkit.org/attachment.cgi?id=101775&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
Looks good.  I like the uniform declarations with this approach; it's much
clearer which features are needed for each IDL entry.


More information about the webkit-reviews mailing list