[webkit-reviews] review denied: [Bug 66884] Speed up texImage from BGRA : [Attachment 105207] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied John Bauman
<jbauman at chromium.org>'s request for review:
Bug 66884: Speed up texImage from BGRA
https://bugs.webkit.org/show_bug.cgi?id=66884

Attachment 105207: Patch
https://bugs.webkit.org/attachment.cgi?id=105207&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105207&action=review


> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:481
> +	   uint32_t rgba = (((bgra >> 16) | (bgra << 16)) & 0x00ff00ff) | (bgra
& 0xff00ff00);

Sorry, I just realized that this won't work correctly on big-endian hardware.
You can use #if CPU(BIG_ENDIAN) to gate the code (see
html/canvas/DataView.cpp); could you please add another arm?