[webkit-reviews] review granted: [Bug 66659] REGRESSION (r88115): Uploading a file to mydrive.ch produces an endless busyloop. : [Attachment 105307] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 66659: REGRESSION (r88115): Uploading a file to mydrive.ch produces an
endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659

Attachment 105307: Patch
https://bugs.webkit.org/attachment.cgi?id=105307&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105307&action=review


>>> Source/WebCore/rendering/RenderFileUploadControl.cpp:69
>>> +	     if (button->disabled() != newDisabled)
>>> +		 button->setDisabled(newDisabled);
>> 
>> Could we put this early return inside the setDisabled function instead? It
seems wrong for setDisabled to trigger style recalculation if the state is not
changing.
> 
> Sure.

I suggest we add a “why” comment explaining why we need to check the disabled
state instead of unconditionally calling setDisabled.