[webkit-reviews] review granted: [Bug 34763] CSS 2.1 failure: margin-applies-to-015 fails, WebKit does not respect top margin for table captions : [Attachment 105500] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 29 10:40:39 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 34763: CSS 2.1 failure: margin-applies-to-015 fails, WebKit does not
respect top margin for table captions
https://bugs.webkit.org/show_bug.cgi?id=34763

Attachment 105500: Patch
https://bugs.webkit.org/attachment.cgi?id=105500&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105500&action=review


> LayoutTests/ChangeLog:49
> +	   * css2.1/20110323/margin-applies-to-001-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-001-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-001.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-002-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-002-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-002.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-003-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-003-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-003.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-004-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-004-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-004.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-005-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-005-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-005.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-006-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-006-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-006.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-007-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-007-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-007.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-008-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-008-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-008.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-009-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-009-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-009.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-010-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-010-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-010.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-012-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-012-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-012.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-013-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-013-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-013.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-014-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-014-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-014.htm: Added.
> +	   * css2.1/20110323/margin-applies-to-015-expected.png: Added.
> +	   * css2.1/20110323/margin-applies-to-015-expected.txt: Added.
> +	   * css2.1/20110323/margin-applies-to-015.htm: Added.

The expected-* files here need to go in platform-specific results directories.


More information about the webkit-reviews mailing list