[webkit-reviews] review denied: [Bug 66283] [Qt][WK2] Add pixel test support : [Attachment 104017] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 66283: [Qt][WK2] Add pixel test support
https://bugs.webkit.org/show_bug.cgi?id=66283

Attachment 104017: Patch
https://bugs.webkit.org/attachment.cgi?id=104017&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104017&action=review


> Source/WebKit2/WebKit2API.pri:93
> +    $$SOURCE_DIR/WebKit2/Shared/API/c/WKImageQt.h \

This path isn't correct.

> Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:42
> +    const QByteArray &data = buffer.data();

Style, & placement.

> Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:49
> +    const char *ptr = data.data();

Style, * placement.

> Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:67
> +	   hash.addData(reinterpret_cast<const char*>(image.scanLine(row)),
image.width() * 4);

You could use QImage::constScanLine() here to avoid calling detach().
"image.width() * 4" isn't necessarily correct, you should use
QImage::bytesPerLine().