[webkit-reviews] review granted: [Bug 67123] [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API DEFINE in WebKit2 : [Attachment 105482] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 67123: [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API
DEFINE in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67123

Attachment 105482: Patch
https://bugs.webkit.org/attachment.cgi?id=105482&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105482&action=review


Looks sane.

> Source/WebKit2/ChangeLog:3
> +	   [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API
DEFINE in WebKit2

s/DEFINE/define/

> Source/WebKit2/WebKit2.pro:582
> +	   DEFINES += PLUGIN_ARCHITECTURE_UNSUPPORTED

Indentation should be 4 spaces here, not 8.