[webkit-reviews] review requested: [Bug 67079] Replace usages of Vector<UChar> with existing StringBuilder : [Attachment 105473] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 29 01:24:30 PDT 2011


Xianzhu Wang <wangxianzhu at chromium.org> has asked  for review:
Bug 67079: Replace usages of Vector<UChar> with existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67079

Attachment 105473: patch
https://bugs.webkit.org/attachment.cgi?id=105473&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at chromium.org>
The patch is big, but most of the modifications are straight-forward.
StringBuilder is slightly modified:
1) Added StringBuilder::characters() because originally Vector<UChar>::data()
was widely used;
2) Added a minimum size for buffer to match Vector (though further performance
investigations/optimizations should be done in
https://bugs.webkit.org/show_bug.cgi?id=67084).


More information about the webkit-reviews mailing list