[webkit-reviews] review granted: [Bug 63878] Add support for constructor syntax for Events : [Attachment 105451] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 63878: Add support for constructor syntax for Events
https://bugs.webkit.org/show_bug.cgi?id=63878

Attachment 105451: Patch
https://bugs.webkit.org/attachment.cgi?id=105451&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105451&action=review


> Source/WebCore/bindings/js/JSEventConstructors.cpp:55
> +	   // FIXME: Not all conversions require this exception check.

does this really warrant a fixme? it's a single indirect read that doesn't
cause any harm.  If anything you should have another exception check before the
convertValue call -- getValue can execute arbitrary js so can throw