[webkit-reviews] review granted: [Bug 67068] Flash of black at the end of full screen transition at apple.com product videos : [Attachment 105421] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 27 12:50:17 PDT 2011


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 67068: Flash of black at the end of full screen transition at apple.com
product videos
https://bugs.webkit.org/show_bug.cgi?id=67068

Attachment 105421: Patch
https://bugs.webkit.org/attachment.cgi?id=105421&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105421&action=review


> Source/WebKit2/ChangeLog:25
> +	   (WebKit::WebFullScreenManagerMac::animateFullScreen): Content layer
is now last().

Wouldn’t it be better to have a function named contentLayer to document what
we’re doing instead of having multiple places know to call last to get at it?


More information about the webkit-reviews mailing list