[webkit-reviews] review requested: [Bug 63553] SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end : [Attachment 105436] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 27 06:55:36 PDT 2011


Young Han Lee <joybro at company100.net> has asked  for review:
Bug 63553: SVG animation fill="freeze" doesn't set baseVal to current animVal
if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

Attachment 105436: Patch
https://bugs.webkit.org/attachment.cgi?id=105436&action=review

------- Additional Comments from Young Han Lee <joybro at company100.net>
animate.setAttribute("begin", "click");
animate.setAttribute("end", "2s");

The test was wrong. The SVG animation in the test started when a 'click' event
occurs and ended at '2s'. It was a mistake because I actually wanted to stop
the animation 2 seconds after the animation starts. I changed the test as
follows.

animate.setAttribute("begin", "click");
animate.setAttribute("end", "click+2s");


More information about the webkit-reviews mailing list