[webkit-reviews] review granted: [Bug 59146] Implement requestAnimationFrame on Mac : [Attachment 105423] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 59146: Implement requestAnimationFrame on Mac
https://bugs.webkit.org/show_bug.cgi?id=59146

Attachment 105423: Patch
https://bugs.webkit.org/attachment.cgi?id=105423&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105423&action=review


> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:593
> +    WebPage* webPage = static_cast<WebPage*>(context);
> +    webPage->unscheduleAnimation();

Since it's one-shot, you don't really need to invalidate it (just to null out
the pointer).

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:598
> +	  
webPage->corePage()->mainFrame()->view()->serviceScriptedAnimations(convertSeco
ndsToDOMTimeStamp(currentTime()));

Would be better with some local variables for Page and Frame.