[webkit-reviews] review granted: [Bug 67062] Implement NPN_ScheduleTimer/NPN_UnscheduleTimer : [Attachment 105402] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 26 13:45:56 PDT 2011
Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 67062: Implement NPN_ScheduleTimer/NPN_UnscheduleTimer
https://bugs.webkit.org/show_bug.cgi?id=67062
Attachment 105402: Patch
https://bugs.webkit.org/attachment.cgi?id=105402&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105402&action=review
> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:338
> +void NetscapePlugin::Timer::start(bool throttle)
> +{
Please remove the parameter.
> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:256
> + NetscapePlugin* m_netscapePlugin;
Please put a comment here explaining the lifetime of this pointer.
More information about the webkit-reviews
mailing list