[webkit-reviews] review denied: [Bug 66901] Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases : [Attachment 105208] Version 2: Should fix windows bot.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 66901: Enable RenderLayer::updateLayerPosition's cachedOffset optimization
for more cases
https://bugs.webkit.org/show_bug.cgi?id=66901

Attachment 105208: Version 2: Should fix windows bot.
https://bugs.webkit.org/attachment.cgi?id=105208&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105208&action=review


> Source/WebCore/page/FrameView.cpp:1064
> +    bool disabled;

Rename to cachedOffsetDisabled.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:362
> +		   // There is only one layer to update, it is not worth using
|cachedOffset| since
> +		   // we are not sure the value will be used.
> +		   static LayoutPoint* disabledCachedOffset = 0;
> +		   m_layer->updateLayerPositions(disabledCachedOffset);

I don't understand this change.

> Source/WebCore/rendering/RenderLayer.cpp:264
> +    // prevent the optimization to work.

"from working" would read better than "to work"

> Source/WebCore/rendering/RenderLayer.h:311
> +    void updateLayerPositions(LayoutPoint* cachedOffset,
UpdateLayerPositionsFlags = defaultFlags);

Allow the cachedOffset to be 0 still and you wouldn't have to change
RenderBoxModelObject.