[webkit-reviews] review granted: [Bug 67035] Modify the build bot master's script to pass --chromium-android where appropriate : [Attachment 105356] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Peter Beverloo
<peter at chromium.org>'s request for review:
Bug 67035: Modify the build bot master's script to pass --chromium-android
where appropriate
https://bugs.webkit.org/show_bug.cgi?id=67035

Attachment 105356: Patch
https://bugs.webkit.org/attachment.cgi?id=105356&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105356&action=review


> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:91
> +def appendCustomBuildFlags(step, platform, fullPlatform=""):

I see.	The issue here is that we're cross-compiling.  Maybe rather than
"fullPlatform" we should say target_os ?

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:92
> +    if fullPlatform == "chromium-android":

This this becomes platform == "chromium" && target_os == "android".

That will generalize better if we want to support other sorts of cross
compiling (e.g., building on Linux but targeting Mac).