[webkit-reviews] review denied: [Bug 66877] [Chromium] Add ability to do static SerializedScriptValue deserialization : [Attachment 105378] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 66877: [Chromium] Add ability to do static SerializedScriptValue
deserialization
https://bugs.webkit.org/show_bug.cgi?id=66877

Attachment 105378: Patch
https://bugs.webkit.org/attachment.cgi?id=105378&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105378&action=review


> Source/WebKit/chromium/public/WebSerializedScriptValue.h:65
> +    WEBKIT_EXPORT static WebSerializedScriptValue
fromValue(v8::Handle<v8::Value>);

Perhaps it would be better to name this function serialize to parallel the
deserialize function.  I'm guessing you went with from* to match fromString.
Maybe the difference there is that fromString is really just taking the
serialized bytes and storing them in a WebSerializedScriptValue.  It is not
performing any parsing of the data.

> Source/WebKit/chromium/public/WebSerializedScriptValue.h:68
> +

nit: only one new line here