[webkit-reviews] review denied: [Bug 66994] Implement Error.stack : [Attachment 105364] patch w win and chromium fixes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 26 10:41:07 PDT 2011
Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 66994: Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Attachment 105364: patch w win and chromium fixes
https://bugs.webkit.org/attachment.cgi?id=105364&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
Please return an array rather than a string. There are plenty of places where
having programatic knowledge of the stack trace would be useful (say the
inspector), by creating a single string you're essentially requiring users to
manually parse the string you just built up back into an array.
More information about the webkit-reviews
mailing list