[webkit-reviews] review granted: [Bug 66957] Unzip initialization lists and constructors in JSCell hierarchy (2/7) : [Attachment 105291] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 66957: Unzip initialization lists and constructors in JSCell hierarchy
(2/7)
https://bugs.webkit.org/show_bug.cgi?id=66957

Attachment 105291: Patch
https://bugs.webkit.org/attachment.cgi?id=105291&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105291&action=review


> Source/JavaScriptCore/runtime/Executable.h:221
> +#else
> +	   void finishCreation(JSGlobalData& globalData)
> +	   {
> +	       Base::finishCreation(globalData);
> +	   }
> +#endif

Why is this needed? Don’t we already inherit the base function? Not sure why
we’d need to override it with an inline that does the same thing.

> Source/JavaScriptCore/runtime/Executable.h:291
> +	       UNUSED_PARAM(globalData);

This is incorrect. The parameter is passed to the base class version of
finishCreation so it is used.