[webkit-reviews] review granted: [Bug 65884] New Layout tests needed for WebVTT cue text parsing rules : [Attachment 105365] Eric's suggestions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 26 09:53:45 PDT 2011
Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 65884: New Layout tests needed for WebVTT cue text parsing rules
https://bugs.webkit.org/show_bug.cgi?id=65884
Attachment 105365: Eric's suggestions
https://bugs.webkit.org/attachment.cgi?id=105365&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105365&action=review
> LayoutTests/media/video-test.js:252
> + testExpected("cues[i]." + test.property, test.values[i]);
Suggestion: for a future modification you might consider changing this so the
track number is printed as it is in the tests that don't use this function.
IOW, something like this:
testExpected("cues[" + i + "]." + test.property, test.values[i]);
so the results look like this:
EXPECTED (cues[0].direction == 'vertical') OK
instead of this:
EXPECTED (cues[i].direction == 'vertical') OK
More information about the webkit-reviews
mailing list