[webkit-reviews] review requested: [Bug 67034] Teach scripts how to handle the building env. for the Chromium port on OS(ANDROID) : [Attachment 105355] Patch

[bugzilla-daemon at webkit.org]

Peter Beverloo <peter at chromium.org> has asked  for review:
Bug 67034: Teach scripts how to handle the building env. for the Chromium port
on OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=67034

Attachment 105355: Patch
https://bugs.webkit.org/attachment.cgi?id=105355&action=review

------- Additional Comments from Peter Beverloo <peter at chromium.org>
Building WebKit for Android requires the toolchain from Android's NDK to be
used. Furthermore, the project files need to be taught that OS=android and the
DEPS file should be able to have custom dependencies for Android. This patch
introduces the --chromium-android command line switch for update-webkit,
update-webkit-chromium and build-webkit.

It's a bit rough right now, and I'm mostly curious to your opinions about the
environment variables being set in webkitdirs.pm. Is this the right approach?