[webkit-reviews] review denied: [Bug 65969] [Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently : [Attachment 105325] Patch

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 65969: [Qt]
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails
intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969

Attachment 105325: Patch
https://bugs.webkit.org/attachment.cgi?id=105325&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105325&action=review


> Source/WebCore/page/FrameView.cpp:2754
> +    HashSet<RefPtr<FrameView> > frameViews;
> +    collectFrameViewChildren(this, frameViews);

Why do you use HashSet<> here? For me it seems a simple Vector would be enough
which is much faster and use less sytem resources.