[webkit-reviews] review denied: [Bug 66918] Chromium Win: Setting square-button appearance reaches NOTREACHED : [Attachment 105311] added test

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 66918: Chromium Win: Setting square-button appearance reaches NOTREACHED
https://bugs.webkit.org/show_bug.cgi?id=66918

Attachment 105311: added test
https://bugs.webkit.org/attachment.cgi?id=105311&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105311&action=review


> LayoutTests/ChangeLog:8
> +	   * fast/css/square-button-appearance.html: Added. Test rendering of
square-button appearance.

You should add this test to test_expectations.txt.  Otherwise, layout tests on
ports other than chromium-win and mac-snowleopard fail.

> LayoutTests/ChangeLog:12
> +	   *
platform/mac-snowleopard/fast/css/square-button-appearance-expected.png: Added.

> +	   *
platform/mac-snowleopard/fast/css/square-button-appearance-expected.txt: Added.


Do you think these results are not compatible with Lion?  If you're not sure
about it, I recommend you don't add results for Mac.

> LayoutTests/fast/css/square-button-appearance.html:18
> +<h1>Test if square-button appearance is rendered properly.</h1>

Please change this line to a comment.  Texts prevent test result sharing.
<!-- Test if square-button appearance is rendered properly. -->