[webkit-reviews] review denied: [Bug 67015] REGRESSION(r93390): Invalid maxlength attribute causes input to allow no text : [Attachment 105302] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 67015: REGRESSION(r93390): Invalid maxlength attribute causes input to
allow no text
https://bugs.webkit.org/show_bug.cgi?id=67015

Attachment 105302: Patch
https://bugs.webkit.org/attachment.cgi?id=105302&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105302&action=review


> LayoutTests/ChangeLog:3
> +	   Empty or invalid maxlength of an input tag should be ignored.

Please prepend "REGRESSION(r93390): " to the summary.  It's a WebKit idiom for
a regression.

> Source/WebCore/ChangeLog:3
> +	   Empty or invalid maxlength of an input tag should be ignored.

ditto.

> Source/WebCore/html/HTMLInputElement.cpp:1926
> +    bool ok = true;
> +    int maxLength = attribute->isNull() ? maximumLength :
attribute->value().toInt(&ok);
> +    if (!ok || maxLength < 0 || maxLength > maximumLength)

Please use parseHTMLInteger() in WebCore/html/parser/HTMLParserIdioms.h