[webkit-reviews] review granted: [Bug 66984] Enum-ify ResourceLoaderOptions/ThreadableLoaderOptions : [Attachment 105260] Update Notification.cpp too
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 25 16:59:05 PDT 2011
David Levin <levin at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 66984: Enum-ify ResourceLoaderOptions/ThreadableLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=66984
Attachment 105260: Update Notification.cpp too
https://bugs.webkit.org/attachment.cgi?id=105260&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105260&action=review
> Source/WebCore/loader/cache/CachedResourceRequest.cpp:128
> +
ResourceLoaderOptions(sendResourceLoadCallbacks ? SendCallbacks :
DoNotSendCallbacks, SniffContent, BufferData));
You may want to consider making this function take the enum instead of a bool.
More information about the webkit-reviews
mailing list