[webkit-reviews] review granted: [Bug 66992] garden-o-matic summary view should provide information on builders still in flight. : [Attachment 105267] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 66992: garden-o-matic summary view should provide information on builders
still in flight.
https://bugs.webkit.org/show_bug.cgi?id=66992

Attachment 105267: Patch
https://bugs.webkit.org/attachment.cgi?id=105267&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review


Very nice.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/controllers.js:97
> +	   var failsFromRevision = failureAnalysis.newestPassingRevision + 1;

I'd put the word "implied" into the name of this variable (e.g.,
impliedFirstFailingRevision or something).  We don't actually know that the
test fails in this revision.

Sorry to be so nit-picky about these revision range things.  We weren't careful
about this sort of thing in webkitpy and we paid for it severely later.