[webkit-reviews] review granted: [Bug 66964] Return the correct value for NPNVsupportsCarbonBool : [Attachment 105236] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 25 13:24:42 PDT 2011
Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 66964: Return the correct value for NPNVsupportsCarbonBool
https://bugs.webkit.org/show_bug.cgi?id=66964
Attachment 105236: Patch
https://bugs.webkit.org/attachment.cgi?id=105236&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105236&action=review
>
Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp:
56
> + bool testConvert(double x, double y, NPCoordinateSpace sourceSpace,
NPCoordinateSpace destSpace)
> + {
> + // First convert from src to dest.
> + double destX, destY;
> + if (!NPN_ConvertPoint(x, y, sourceSpace, &destX, &destY, destSpace))
> + return false;
> +
> + // Then convert back to src
> + double srcX, srcY;
> + if (!NPN_ConvertPoint(destX, destY, destSpace, &srcX, &srcY,
sourceSpace))
> + return false;
> +
> +
> + // Then compare.
> + if (srcX != x || srcY != y)
> + return false;
> +
> + return true;
> + }
This function never seems to be called.
>
Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp:
58
> + bool runTest()
This can be private.
More information about the webkit-reviews
mailing list