[webkit-reviews] review granted: [Bug 21586] SVG CSS properties don't work with CSS transitions : [Attachment 105100] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 21586: SVG CSS properties don't work with CSS transitions
https://bugs.webkit.org/show_bug.cgi?id=21586

Attachment 105100: Patch
https://bugs.webkit.org/attachment.cgi?id=105100&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105100&action=review


> LayoutTests/transitions/resources/transition-test-helpers.js:88
> +	   if (isCloseEnough(parseInt(computedValue.red.cssText),
expectedValue[0], tolerance) &&
> +	       isCloseEnough(parseInt(computedValue.green.cssText),
expectedValue[1], tolerance) &&
> +	       isCloseEnough(parseInt(computedValue.blue.cssText),
expectedValue[2], tolerance))

You could put these into a compareRGBColor function.

> LayoutTests/transitions/svg-transitions-expected.txt:12
> +FAIL - "fill" property for "rect7" element at 1s expected: 0,0,127 but saw:
#invalid #0000ff

Did you mean to check in a failing result?

> Source/WebCore/page/animation/AnimationBase.cpp:674
> +class PropertyWrapperSVGPaint : public PropertyWrapperBase {

The name is awkward.