[webkit-reviews] review granted: [Bug 66398] Add MediaPlayer::audioSourceProvider() method for audio stream access by the Web Audio API. : [Attachment 104886] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 66398: Add MediaPlayer::audioSourceProvider() method for audio stream
access by the Web Audio API.
https://bugs.webkit.org/show_bug.cgi?id=66398

Attachment 104886: Patch
https://bugs.webkit.org/attachment.cgi?id=104886&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104886&action=review


> Source/WebCore/ChangeLog:36
> +	   * html/HTMLMediaElement.cpp:
> +	   (WebCore::HTMLMediaElement::HTMLMediaElement):
> +	   (WebCore::HTMLMediaElement::prepareForLoad):
> +	   (WebCore::HTMLMediaElement::loadNextSourceChild):
> +	   (WebCore::HTMLMediaElement::ensureMediaPlayer):
> +	   (WebCore::HTMLMediaElement::createMediaPlayer):
> +	   (WebCore::HTMLMediaElement::setAudioSourceNode):
> +	   (WebCore::HTMLMediaElement::audioSourceProvider):
> +	   * html/HTMLMediaElement.h:
> +	   (WebCore::HTMLMediaElement::audioSourceNode):
> +	   * platform/graphics/MediaPlayer.cpp:
> +	   (WebCore::MediaPlayer::audioSourceProvider):
> +	   * platform/graphics/MediaPlayer.h:
> +	   * platform/graphics/MediaPlayerPrivate.h:
> +	   (WebCore::MediaPlayerPrivateInterface::audioSourceProvider):
> +	   * webaudio/AudioContext.cpp:
> +	   (WebCore::AudioContext::createMediaElementSource):
> +	   * webaudio/AudioContext.h:
> +	   * webaudio/AudioContext.idl:
> +	   * webaudio/MediaElementAudioSourceNode.cpp:
> +	   (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):

> +	  
(WebCore::MediaElementAudioSourceNode::~MediaElementAudioSourceNode):
> +	   (WebCore::MediaElementAudioSourceNode::process):
> +	   * webaudio/MediaElementAudioSourceNode.h:
> +	   (WebCore::MediaElementAudioSourceNode::lock):
> +	   (WebCore::MediaElementAudioSourceNode::unlock):

It would be helpful to have comments here about what changed in each function.