[webkit-reviews] review granted: [Bug 66939] add a state enumeration to track down cause of null CachedScript execution : [Attachment 105187] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 66939: add a state enumeration to track down cause of null CachedScript
execution
https://bugs.webkit.org/show_bug.cgi?id=66939

Attachment 105187: Patch
https://bugs.webkit.org/attachment.cgi?id=105187&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105187&action=review


> Source/WebCore/dom/ScriptElement.h:114
> +	 NEVER_SET,
> +	 SET,
> +	 ZEROED_IN_STOPLOADREQUEST,
> +	 ZEROED_IN_NOTIFYFINISHED,

This is not correct coding style. Macros are ALL_CAPS, enum values are AllCaps.
Also, I don't believe that volatile can possibly help.