[webkit-reviews] review denied: [Bug 66858] Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame : [Attachment 105171] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 25 07:38:05 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 66858: Web Inspector: [refactoring] use PopoverHelper to implement popup in
the SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=66858
Attachment 105171: patch
https://bugs.webkit.org/attachment.cgi?id=105171&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105171&action=review
> Source/WebCore/inspector/front-end/SourceFrame.js:725
> + if (wasThrown || !this._delegate.debuggerPaused()) {
Should you check for popover.disposed as a start?
More information about the webkit-reviews
mailing list