[webkit-reviews] review canceled: [Bug 66858] Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame : [Attachment 105151] patch (!= => !===)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 25 06:35:09 PDT 2011


Andrey Kosyakov <caseq at chromium.org> has canceled Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 66858: Web Inspector: [refactoring] use PopoverHelper to implement popup in
the SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=66858

Attachment 105151: patch (!= => !===)
https://bugs.webkit.org/attachment.cgi?id=105151&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
- move content element from Popover constructor to Popover.show()
- create popover in PopoverHelper rather than in client code
- rename most occurrences of "popup" to popover.


More information about the webkit-reviews mailing list