[webkit-reviews] review granted: [Bug 66771] [Qt][WK2] Drive tiling from the WebProcess and reuse TiledBackingStore. : [Attachment 105047] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 66771: [Qt][WK2] Drive tiling from the WebProcess and reuse
TiledBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=66771

Attachment 105047: Patch
https://bugs.webkit.org/attachment.cgi?id=105047&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105047&action=review


Nice stuff!! A few fixes before landing:

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:105
> +    HashMap<int, int> m_tileNodeMap;

Comment please about what the two ints represent

> Source/WebKit2/UIProcess/qt/SGTileNode.cpp:33
> +    , m_material(0)
> +    , m_opaqueMaterial(0)

I think it would be better with a single boolean, as these two are acting as
booleans in the code below, and might become dangling pointers if someone calls
setMaterial() without updating m_material.