[webkit-reviews] review denied: [Bug 66769] Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel. : [Attachment 104831] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 66769: Web Inspector: rename sourceFile to (raw|ui)SourceCode in
DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=66769

Attachment 104831: Patch
https://bugs.webkit.org/attachment.cgi?id=104831&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104831&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:36
> +    this._uiSourceCode = {};

I thought ui source code items belong to corresponding raw source code items.

> Source/WebCore/inspector/front-end/SourceFile.js:77
> +	   uiLocation.uiSourceCode = this;

Defining class for UILocation would help understanding the code.