[webkit-reviews] review denied: [Bug 66858] Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame : [Attachment 104999] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 66858: Web Inspector: [refactoring] use PopoverHelper to implement popup in
the SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=66858

Attachment 104999: patch
https://bugs.webkit.org/attachment.cgi?id=104999&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104999&action=review


> Source/WebCore/inspector/front-end/Popover.js:185
> +	   this._popup = value;

You should not expose popup setter.

> Source/WebCore/inspector/front-end/SourceFrame.js:695
> +	   return element;

For the expression

foo.bar.baz, the anchor element should be "foo" span.