[webkit-reviews] review granted: [Bug 66488] [chromium] Leaking SkBitmaps for background images : [Attachment 105099] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted John Bates
<jbates at google.com>'s request for review:
Bug 66488: [chromium] Leaking SkBitmaps for background images
https://bugs.webkit.org/show_bug.cgi?id=66488

Attachment 105099: Patch
https://bugs.webkit.org/attachment.cgi?id=105099&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105099&action=review


Looks good.  r=me

> Source/WebCore/platform/graphics/skia/NativeImageSkia.h:67
> +    SkBitmap& bitmap() { return m_image; }

I'm not a fan of returning a non-const reference (although that's not webkit
coding style or anything, just personal preference).  Out of curiosity, how
many call sites break with only the const ref variant available?

> Source/WebCore/platform/graphics/skia/PatternSkia.cpp:62
> +    const NativeImageSkia* bm = m_tileImage->nativeImageForCurrentFrame();

Nit:  Might make sense to rename "bm" to "image" now that it's a
NativeImageSkia and not a bitmap.