[webkit-reviews] review granted: [Bug 66434] [chromium] Update VideoLayerChromium to not access GC3D on the main thread : [Attachment 105111] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 66434: [chromium] Update VideoLayerChromium to not access GC3D on the main
thread
https://bugs.webkit.org/show_bug.cgi?id=66434

Attachment 105111: Patch
https://bugs.webkit.org/attachment.cgi?id=105111&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105111&action=review


R=me.

The TextureManager right now doesn't know how much memory different texture
formats take up (see memoryUseBytes in TextureManager.cpp).  That might be
worth fixing now that we're managing non-RGBA textures, could you file a bug
for that? The current code is a bit pessimistic but not obviously harmful.

> Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:72
> +void CCVideoLayerImpl::setTexture(size_t idx, Platform3DObject textureId,
const IntSize& size, const IntSize& visibleSize)

we don't abbreviate in WebKit, although we do use 'i' so either 'i' or 'index'
are good but not 'idx'