[webkit-reviews] review granted: [Bug 66849] The GC does not have a facility for profiling the kinds of objects that occupy the heap : [Attachment 105063] the patch (fix style)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 24 14:15:51 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 66849: The GC does not have a facility for profiling the kinds of objects
that occupy the heap
https://bugs.webkit.org/show_bug.cgi?id=66849

Attachment 105063: the patch (fix style)
https://bugs.webkit.org/attachment.cgi?id=105063&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105063&action=review


r=me

> Source/JavaScriptCore/heap/VTableSpectrum.cpp:109
> +	       fprintf(output, "    %s:%s(%p): %lu\n", strippedFileName,
info.dli_sname, item.vtable, (long unsigned)item.count);

I think you can remove this "(long unsigned)" cast now.


More information about the webkit-reviews mailing list