[webkit-reviews] review granted: [Bug 45202] Intermittent crashes in EventSource::close() : [Attachment 105040] + test fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 45202: Intermittent crashes in EventSource::close()
https://bugs.webkit.org/show_bug.cgi?id=45202

Attachment 105040: + test fix
https://bugs.webkit.org/attachment.cgi?id=105040&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105040&action=review


r=me. It would be great if you could get rid of EventSender before landing.

>
LayoutTests/http/tests/eventsource/eventsource-reconnect-during-navigate-crash.
html:16
> +	   eventSender.mouseMoveTo(a.offsetLeft + 2, a.offsetTop + 2);
> +	   eventSender.mouseDown();
> +	   eventSender.mouseUp();

Does no other way to navigate work? I would expect that setting window.location
is no different.

It would be nice to have the test work in browser and in ports that don't'
support eventSender.

> LayoutTests/http/tests/eventsource/resources/wait-then-notify-done.php:7
> +sleep(1);
> +echo "<script> if (window.layoutTestController)
layoutTestController.notifyDone()</script>\n";

Sadness.