[webkit-reviews] review denied: [Bug 61167] Middle clicking a named target sets a focus to a previously opened page : [Attachment 103222] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 61167: Middle clicking a named target sets a focus to a previously opened
page
https://bugs.webkit.org/show_bug.cgi?id=61167

Attachment 103222: Patch
https://bugs.webkit.org/attachment.cgi?id=103222&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103222&action=review


> Source/WebCore/loader/FrameLoader.cpp:198
> +    , m_navigationPolicy(NavigationPolicyCurrentTab)

Why is this a property of the loader and not of the load itself?

> Source/WebCore/loader/FrameLoader.cpp:1173
> +    m_navigationPolicy = NavigationPolicyCurrentTab;

What about all the other APIs for triggering navigations.  As you've written
the patch, it seems like they're re-use whatever value m_navigationPolicy
happens to be set to.