[webkit-reviews] review granted: [Bug 66023] Web Inspector: Console logging of arrays is not useful : [Attachment 104482] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 24 02:16:23 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 66023: Web Inspector: Console logging of arrays is not useful
https://bugs.webkit.org/show_bug.cgi?id=66023

Attachment 104482: Patch
https://bugs.webkit.org/attachment.cgi?id=104482&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104482&action=review


>
LayoutTests/platform/chromium/inspector/console/console-eval-undefined-override
-expected.txt:4
> +{a:1, self:, __proto__:}

There should be a value even if it's recursive.

> Source/WebCore/inspector/front-end/ConsoleView.js:796
>	       if (name == parseInt(name))

Remove this and next lines and break when the length property is found.


More information about the webkit-reviews mailing list