[webkit-reviews] review granted: [Bug 66756] Implement an Event constructor in V8 : [Attachment 104960] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara <haraken at google.com>'s
request for review:
Bug 66756: Implement an Event constructor in V8
https://bugs.webkit.org/show_bug.cgi?id=66756

Attachment 104960: Patch
https://bugs.webkit.org/attachment.cgi?id=104960&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104960&action=review


> Source/WebCore/bindings/generic/EventConstructors.h:40
> +#define SETUP_EVENT_CONFIGURATION_FOR_ALL_EVENTS(DICTIONARY_START,
DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) \
> +    SETUP_EVENT_CONFIGURATION_FOR_EVENT(DICTIONARY_START, DICTIONARY_END,
FILL_PARENT_PROPERTIES, FILL_PROPERTY)

I still don't fully understand why SETUP_EVENT_CONFIGURATION_FOR_ALL_EVENTS is
any different from SETUP_EVENT_CONFIGURATION_FOR_EVENT.